redhat-actions / crda

Scan your project's dependencies with Code Ready Dependency Analytics
https://github.com/marketplace/actions/codeready-dependency-analytics
MIT License
16 stars 14 forks source link

Fix logic to fail crda workflow in case of pull requests check #26

Closed divyansh42 closed 3 years ago

divyansh42 commented 3 years ago

I think fail_on input doesn't work very well for a CI workflow. Ideally, before failing we should upload the SARIF to GitHub. So that users are aware of which deps made the workflow fail. and the other thing, if for a PR admin sets fail_on to never as he wants to see vuln. uploaded on GH security tab, but he will get CRDA scan passed in the label. Both the things are kind of contradictory, on one side he is getting vuln in the security tab, and also he is getting crda scan passed. Probably we should update the labels: