redhat-actions / openshift-tools-installer

Download, install and cache OpenShift binaries into your GitHub Actions runners.
https://github.com/marketplace/actions/openshift-tools-installer
MIT License
22 stars 21 forks source link

[BUG] CRC latest version (1.31.2) install failing on windows runners #50

Open divyansh42 opened 2 years ago

divyansh42 commented 2 years ago

It seems like after the latest (1.31.2) update, CRC executable is not present inside the zipped package for the windows. .msi file is present which will have different installation mechanism.

divyansh42 commented 2 years ago

https://github.com/code-ready/crc/issues/2717

gbraad commented 2 years ago

Use msiexec to install CRC using the MSI.

tetchel commented 2 years ago

there are a few options. it looks like the runners should have admin permissions so that should not block us.

1) use msiexec and make crc windows a special case 2) allow downloading crc-windows but then just leave the msi in the bin and leave it to the user to install it (also we'd have to disable the version exec) 3) drop support for crc windows (we already dropped crc mac)

i think 1) is probably less work than 2) tbh so let's explore that option.