search

redhat-actions / push-to-registry

GitHub Action to push a container image to an image registry.
https://github.com/marketplace/actions/push-to-registry
MIT License
100 stars 33 forks source link

Fail the action if input `image` contains any `/` in it's name. #38

Closed divyansh42 closed 3 years ago

divyansh42 commented 3 years ago

There might be case when user provide / in the image name. Example: namespace/imageName If above image is provided then the action will fail to push the image to registry (only valid when image is present in docker storage) So, We should throw an error and fail the action right away, stating / is not allowed in the image name

Ref: #37

andmos commented 3 years ago

It's and easy mistake to make, since lots of people building local images on their own computers do it in the form docker build -t namespace/imagename ., so it should be quite clear if it's not supported 👍

divyansh42 commented 3 years ago

Yeah, we will try to make it clear in the documentation too.