redhat-actions / push-to-registry

GitHub Action to push a container image to an image registry.
https://github.com/marketplace/actions/push-to-registry
MIT License
100 stars 33 forks source link

[FIX] Don't add docker.io prefix to ECR images #69

Closed der-eismann closed 1 year ago

der-eismann commented 2 years ago

Description

The action assumes that if image.split("/").length == 2, the image must be from Docker hub instead of e.g. quay.io, where the value would be 3 (for example for quay.io/foreman/foreman:3.2-stable). But for AWS ECR (e.g. 123456789101.dkr.ecr.eu-west-1.amazonaws.com/example-project:master) the value is also 2, so it adds the prefix even though it is not needed which breaks the action.

Related Issue(s)

68

Checklist

Changes made

der-eismann commented 2 years ago

I can confirm that this branch fixes our problems with the breaking builds. It would still be nice to disable the docker stuff altogether, but this is more important now.

der-eismann commented 2 years ago

@divyansh42 Can you provide any feedback on this PR?

der-eismann commented 1 year ago

@divyansh42 can you please get this in as well?

divyansh42 commented 1 year ago

@der-eismann could you please force push again? So that we can run the checks.

der-eismann commented 1 year ago

I think you need to approve the workflows first before they run

divyansh42 commented 1 year ago

I think you need to approve the workflows first before they run

For some reason, earlier I was not able to see that option. Now it is there. approved the workflow run.

der-eismann commented 1 year ago

Thank you for merging!

divyansh42 commented 1 year ago

@der-eismann I have updated the tags, changes should reflect in v2, v2.7 and v2.7.1