Closed sukantadash closed 1 month ago
Updated "Installation.md"
By default, the script uses the repository (https://github.com/redhat-ai-services/ai-accelerator.git)
and the main branch. The script will prompt for a different repository and branch if desired. If alternate values are provided, the following will occur:
cluster-config-app-of-apps
application in ArgoCD will show as out-of-sync. If manually synced, the repository will revert to the default (https://github.com/redhat-ai-services/ai-accelerator.git)
repo.There are some ideas I think I like here, and a few I don't.
I was originally hesitant to like the idea of not having the patch already configured on all of the cluster folders but I feel like I am starting to come around to the idea. The fact that we can add the patch in when needed feels like a good compromise when we want to make a change for a specific cluster, and having the config only in the app of apps does make the setting feel a bit simpler.
I'm not crazy about the fact that the changes are not getting committed back to the repo and that we are simply relying "not syncing" for the changes.
I think we would be better off committing the changes, and then adding in the checks on #46 (with some updates to account for the change in location) to verify the repo was reset on a PR back to our repo.
Instead of hardcoding the repo URL into the bootstrap script we could possibly try to incorporate some of the ideas I was playing around with in #54 where I am detecting the repo URL from git config --get remote.origin.url
and using that to compare to what is set in the repo to check if it needs to be updated.
Also, there are a few checks that exist in the bootstrap script already around the branch that will need to be updated to work with your changes here.
@sukantadash what would you think about merging that to a branch like repo-bootstrap-updates
and I can try and incorporate some of your changes with some of the things I was trying?
@strangiato looks like I don't have access to create branch repo-bootstrap-updates. I like the idea of committing back the changes to the repo and I have some code changes related to that in my local I will push them to the PR.
@strangiato I have created a new branch repo-bootstrap-updates and merged the changes to that branch.
Please review the changes.
e.g. /clusters/overlays/rhoai-stable-2.10/kustomization.yaml