search

redhat-aqe / review-rot

GNU General Public License v3.0
13 stars 16 forks source link

Gitlab Tests Restructuring #100

Closed sidpremkumar closed 5 years ago

amarza-rh commented 5 years ago

An error in python3:

test/gitlab_tests/test_gitlab.py:305:
...
        except SSLError as e:
>           log.exception('Error during authentification: %s', e.message)
E           AttributeError: 'SSLError' object has no attribute 'message'

The message attribute has been deprecated in PEP-352

Please run tests both from python2 and python3 if the purpose is to maintain compatibility across pythons.

amarza-rh commented 5 years ago

You might also want to cover the following with a test from gitlabstack.py

            except ValueError: 
                mr_date = datetime.datetime.strptime( 
                    mr.created_at, '%Y-%m-%dT%H:%M:%SZ') 
                mr_updated_date = datetime.datetime.strptime( 
                    mr.updated_at, '%Y-%m-%dT%H:%M:%SZ')
amarza-rh commented 5 years ago

LGTM, thanks for your contribution :)