redhat-aqe / review-rot

GNU General Public License v3.0
13 stars 16 forks source link

Fix fetching GitHub comments #124

Closed hluk closed 2 years ago

hluk commented 2 years ago

@pbortlov Please review.

hluk commented 2 years ago

GitHub integration is broken in the latest container image. The error is:

Traceback (most recent call last):
  File "/usr/local/bin/review-rot", line 4, in <module>
    __import__('pkg_resources').run_script('review-rot==1.0', 'review-rot')
  File "/usr/local/lib/python3.6/site-packages/pkg_resources/__init__.py", line 656, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/usr/local/lib/python3.6/site-packages/pkg_resources/__init__.py", line 1453, in run_script
    exec(code, namespace, namespace)
  File "/usr/local/lib/python3.6/site-packages/review_rot-1.0-py3.6.egg/EGG-INFO/scripts/review-rot", line 295, in <module>
    main()
  File "/usr/local/lib/python3.6/site-packages/review_rot-1.0-py3.6.egg/EGG-INFO/scripts/review-rot", line 113, in main
    reviewers_config=reviewers_config,
  File "/usr/local/lib/python3.6/site-packages/review_rot-1.0-py3.6.egg/reviewrot/githubstack.py", line 71, in request_reviews
    show_last_comment=show_last_comment,
  File "/usr/local/lib/python3.6/site-packages/review_rot-1.0-py3.6.egg/reviewrot/githubstack.py", line 138, in get_reviews
    last_comment = self.get_last_comment(pr)
  File "/usr/local/lib/python3.6/site-packages/review_rot-1.0-py3.6.egg/reviewrot/githubstack.py", line 196, in get_last_comment
    if review_comments.total_count > 0:
AttributeError: 'PaginatedList' object has no attribute 'total_count'