redhat-best-practices-for-k8s / certsuite

https://redhat-best-practices-for-k8s.github.io/certsuite/
Apache License 2.0
15 stars 31 forks source link

Possible conflicts between lifecycle-cpu-isolation and lifecycle-pod-scheduling conditions to pass #497

Closed ramperher closed 2 years ago

ramperher commented 2 years ago

While testing the new test called lifecycle-cpu-isolation, included in https://github.com/test-network-function/cnf-certification-test/pull/434, I've found some incompatibilities between this test suite and lifecycle-pod-scheduling one.

I've been testing lifecycle-cpu-isolation with DCI, thanks to this change. I managed to fulfill the conditions needed to pass the test, as you can see in this DCI job. However, as a consequence of these modifications in the pods under test, lifecycle-pod-scheduling is now failing.

I think the problem is the following:

$ oc get runtimeclass -o json
{
    "apiVersion": "v1",
    "items": [
        {
            "apiVersion": "node.k8s.io/v1",
            "handler": "high-performance",
            "kind": "RuntimeClass",
            "metadata": {
                "creationTimestamp": "2022-09-04T06:35:43Z",
                "name": "performance-cnf-basic-profile",
                "ownerReferences": [
                    {
                        "apiVersion": "performance.openshift.io/v2",
                        "blockOwnerDeletion": true,
                        "controller": true,
                        "kind": "PerformanceProfile",
                        "name": "cnf-basic-profile",
                        "uid": "6015b5e4-3f2e-4355-b8f7-7ed1b2129f09"
                    }
                ],
                "resourceVersion": "39865",
                "uid": "3cf9e8b8-7d10-4284-8c4a-95bd5615a914"
            },
            "scheduling": {
                "nodeSelector": {
                    "node-role.kubernetes.io/worker": ""
                }
            }
        }
    ],
    "kind": "List",
    "metadata": {
        "resourceVersion": ""
    }
}

So, my question is, how can we deal with this kind of issue?

ramperher commented 2 years ago

CC @sebrandon1, maybe you are interested in checking this, as you included the CPU isolation test.

sebrandon1 commented 2 years ago

Thanks for the report! I'll take a look.

sebrandon1 commented 2 years ago

Fixed in #498