search

redhat-best-practices-for-k8s / certsuite

https://redhat-best-practices-for-k8s.github.io/certsuite/
Apache License 2.0
15 stars 31 forks source link

Testing of PodDisruptionBudgets makes tnf not working with OCP <= 4.7.x #749

Closed ramperher closed 3 months ago

ramperher commented 1 year ago

I'm opening this issue just to warn you that tnf deployments in OCP versions lower or equal than 4.7 are not working because, when trying to detect the PodDisruptionBudget resources, it fails because this resource is not available for these OCP versions. See example here: https://www.distributed-ci.io/jobs/fdc5b4f2-3c98-45b4-9607-5af707b67c73/files, in execution.log file:

FATAL  [Dec 17 12:42:58.508][autodiscover.go: 140] Cannot get pod disruption budgets, error: the server could not find the requested resource

Just saying this because, in the docs: https://test-network-function.github.io/cnf-certification-test/test-spec/#cnf-specific-tests, minimum OCP version is supposed to be 4.6.0. Probably it should be increased to 4.8.0. Also, take into account that 4.7 is EOL.

sebrandon1 commented 1 year ago

@ramperher is this issue still valid?

mwlinca commented 1 year ago

@ramperher doing some clean up - can this be closed or still relevant?

ramperher commented 1 year ago

@sebrandon1 @mwlinca As OCP 4.7 is EOL, I think this can be closed, but maybe I'd emphazise this and try to include this comment, because this is still valid: Just saying this because, in the docs: https://test-network-function.github.io/cnf-certification-test/test-spec/#cnf-specific-tests, minimum OCP version is supposed to be 4.6.0. Probably it should be increased to 4.8.0. Also, take into account that 4.7 is EOL.

sebrandon1 commented 1 year ago

Good call, we should probably match up the documentation to what versions of OCP that QE is currently testing against. Honestly I think the only thing tying us to a certain version of OCP/k8s is the compatibility with the k8s golang client and k8s version.

However, the compatibility matrix on the client-go README hasn't been updated in some time so I can't say for certain which features work/don't work with a certain version of k8s/OCP/client-go.