:rocket: Adding a logout option for the website

redhat-beyond / JobSeeker

https://github.com/redhat-beyond/JobSeeker

MIT License

2 stars 5 forks source link

:rocket: Adding a logout option for the website #103

Closed amittcohen closed 2 years ago

amittcohen commented 2 years ago

Added a logout option, by doing the following steps:

Updated the urls.py file in the login app to contain a logout option
Configured a LOGOUT_REDIRECT_URL in the settings.py file
Updated the logout button link in the base template
Removed unecessary functions in the views.py file in the login app

closes #71

paOmer commented 2 years ago

Hi @amittcohen, I think that removing the login views.py file content should be moved to its own PR.

Also, I think it would be clearer to the user, that after login out he would get redirected to one of this 2 options:

To the main feed
To a logout template which says to the user he successfully logged out, and there you could add a link to the login page.

amittcohen commented 2 years ago

Hi @amittcohen, I think that removing the login views.py file content should be moved to its own PR.

Also, I think it would be clearer to the user, that after login out he would get redirected to one of this 2 options:

To the main feed

To a logout template which says to the user he successfully logged out, and there you could add a link to the login page.

Regarding the views.py file, I have created another pull request (#116 )

amittcohen commented 2 years ago

@paOmer @Yarboa Added the test