search

redhat-beyond / JobSeeker

https://github.com/redhat-beyond/JobSeeker
MIT License
2 stars 5 forks source link

🐛 Job Board: Fix the search form appearance #129

Closed DeanBiton closed 2 years ago

DeanBiton commented 2 years ago

Close #127

DeanBiton commented 2 years ago

@paOmer Are there tests covers the changes? In case yes please add reference to the codein initial comment.

If not add a test

@Yarboa This PR handles more of a visual error in the HTML that is created by Django. I thought that screenshotting the wanted result will suffice, should I check in a test that the HTML file simply contains the wanted result?

Yarboa commented 2 years ago

@paOmer Are there tests covers the changes? In case yes please add reference to the codein initial comment. If not add a test

@Yarboa This PR handles more of a visual error in the HTML that is created by Django. I thought that screenshotting the wanted result will suffice, should I check in a test that the HTML file simply contains the wanted result?

Do you think there is client a client test cover this part? If not please add a test, else add a link to tests in main branch

Yarboa commented 2 years ago

@paOmer Are there tests covers the changes? In case yes please add reference to the codein initial comment. If not add a test

@Yarboa This PR handles more of a visual error in the HTML that is created by Django. I thought that screenshotting the wanted result will suffice, should I check in a test that the HTML file simply contains the wanted result?

Do you think there is client a client test cover this part? If not please add a test, else add a link to tests in main branch

No reply from you here, in case you do not understand, please contact in slack

DeanBiton commented 2 years ago

@paOmer Are there tests covers the changes? In case yes please add reference to the codein initial comment. If not add a test

@Yarboa This PR handles more of a visual error in the HTML that is created by Django. I thought that screenshotting the wanted result will suffice, should I check in a test that the HTML file simply contains the wanted result?

Do you think there is client a client test cover this part? If not please add a test, else add a link to tests in main branch

No reply from you here, in case you do not understand, please contact in slack

@Yarboa The client tests are located in the #122 PR, so for now there are no tests in the main branch.

Yarboa commented 2 years ago

@paOmer Are there tests covers the changes? In case yes please add reference to the codein initial comment. If not add a test

@Yarboa This PR handles more of a visual error in the HTML that is created by Django. I thought that screenshotting the wanted result will suffice, should I check in a test that the HTML file simply contains the wanted result?

Do you think there is client a client test cover this part? If not please add a test, else add a link to tests in main branch

No reply from you here, in case you do not understand, please contact in slack

@Yarboa The client tests are located in the #122 PR, so for now there are no tests in the main branch.

Thanks, in that case i recommend to finish PR 122, you have more to do with tests over there, please refer my latest comments