redhat-beyond / JobSeeker

https://github.com/redhat-beyond/JobSeeker
MIT License
2 stars 5 forks source link

📝 Updating `README.md` #18

Closed taljacob2 closed 2 years ago

taljacob2 commented 2 years ago

You can view this file on my branch here.

Close #19

Signed-off-by: Tal Jacob taljacob2@gmail.com

taljacob2 commented 2 years ago

Changes are ready for review.

paOmer commented 2 years ago

Looks good and extensive @taljacob2 , maybe consider add our team members to the file

taljacob2 commented 2 years ago

Looks good and extensive @taljacob2 , maybe consider add our team members to the file

Will do.

taljacob2 commented 2 years ago

Looks good and extensive @taljacob2 , maybe consider add our team members to the file

Will do.

I can use your help here. I have already prepared a "Team" section in the CONTRIBUTING.md in #16.

We should avoid duplicates.

So should I link the README.md to the CONTRIBUTING.md's "Teams" section? Or the other way around?

paOmer commented 2 years ago

Looks good and extensive @taljacob2 , maybe consider add our team members to the file

Will do.

I can use your help here. I have already prepared a "Team" section in the CONTRIBUTING.md in #16.

We should avoid duplicates.

So should I link the README.md to the CONTRIBUTING.md's "Teams" section? Or the other way around?

I'm thinking to link the CONTRIBUTING.md to the README.md file and add "if you wish to contribute to our project, please follow along our CONTRIBUTING.md ", as the README file appears on the repo main page.

taljacob2 commented 2 years ago

Looks good and extensive @taljacob2 , maybe consider add our team members to the file

Will do.

I can use your help here. I have already prepared a "Team" section in the CONTRIBUTING.md in #16.

We should avoid duplicates.

So should I link the README.md to the CONTRIBUTING.md's "Teams" section? Or the other way around?

I'm thinking to link the CONTRIBUTING.md to the README.md file and add "if you wish to contribute to our project, please follow along our CONTRIBUTING.md ", as the README file appears on the repo main page.

Okay. So to make sure I understand:

paOmer commented 2 years ago

Looks good and extensive @taljacob2 , maybe consider add our team members to the file

Will do.

I can use your help here. I have already prepared a "Team" section in the CONTRIBUTING.md in #16. We should avoid duplicates. So should I link the README.md to the CONTRIBUTING.md's "Teams" section? Or the other way around?

I'm thinking to link the CONTRIBUTING.md to the README.md file and add "if you wish to contribute to our project, please follow along our CONTRIBUTING.md ", as the README file appears on the repo main page.

Okay. So to make sure I understand:

  • I will keep the "Teams" section in the CONTRIBUTING.md.
  • I will create a link in the README.md that refers to the "Teams" section in CONTRIBUTING.md?

Yeah, keep the "Teams" section in the CONTRIBUTING.md. But, i'm thinking it's best to just mention the CONTRIBUTING.md in the README.md when referring to "if you wish to contribute to our project... " and just drop the part of referring regards to the team. That just my thoughts on it...

taljacob2 commented 2 years ago

Looks good and extensive @taljacob2 , maybe consider add our team members to the file

Will do.

I can use your help here. I have already prepared a "Team" section in the CONTRIBUTING.md in #16. We should avoid duplicates. So should I link the README.md to the CONTRIBUTING.md's "Teams" section? Or the other way around?

I'm thinking to link the CONTRIBUTING.md to the README.md file and add "if you wish to contribute to our project, please follow along our CONTRIBUTING.md ", as the README file appears on the repo main page.

Okay. So to make sure I understand:

  • I will keep the "Teams" section in the CONTRIBUTING.md.
  • I will create a link in the README.md that refers to the "Teams" section in CONTRIBUTING.md?

Yeah, keep the "Teams" section in the CONTRIBUTING.md. But, i'm thinking it's best to just mention the CONTRIBUTING.md in the README.md when referring to "if you wish to contribute to our project... " and just drop the part of referring regards to the team. That just my thoughts on it...

I agree with you. Thanks for support :+1: