🏇 Personal Profile: Adding Deletions Tests and Updating Migrations

redhat-beyond / JobSeeker

https://github.com/redhat-beyond/JobSeeker

MIT License

2 stars 5 forks source link

🏇 Personal Profile: Adding Deletions Tests and Updating Migrations #65

Closed ShirleyFichman closed 2 years ago

ShirleyFichman commented 2 years ago

In this PR you can find the several updates:

Added deletion tests for the personal profile model.
Updated the data migration so the names of the resumes and profile pictures will include the user's name for organizational purposes. Also added a specific path for profile pictures to be saved.
Adding the option for a personal profile to not have a birth date so it's not a requirement.

close #69

paOmer commented 2 years ago

LGTM I don't think it's mandatory but you could squash some of the commits together in order to make this PR clearer.

ShirleyFichman commented 2 years ago

As I discussed in #68, I succeeded in deleting the test files that are created when the pytest runs. The "leftover" files are created from a function in the migrations. That is a bug to fix but it is not related to the tests as I suppose. Therefore I think this PR can be merged, and another PR, hopefully with a fix to that specific bug, will be created separately.

Yarboa commented 2 years ago

In this PR you can find the several updates:

*

If it is several updates, it should be several PRs, sorry @ShirleyFichman

ShirleyFichman commented 2 years ago

In this PR you can find the several updates:

If it is several updates, it should be several PRs, sorry @ShirleyFichman

OK, closing this PR and making new ones.