🏇 Improve Login Form Design Using crispy-forms

[paOmer]

Improved login form design using django-crispy-form package.

django-crispy-forms is a package that helps style forms in django easily. Find more details here.

• Installed the package
• Added the package to the installed apps list
• Set the package to use bootstrap 4
• Used crispy-forms on the login form

New login form screenshot:

Close #90 Close #117

[paOmer]

Please suggest test that it is really working Idea ti use client helper s fixture

Hi @Yarboa, I cant figure out how or what exactly to check here, would appreciate further guidance here

[Yarboa]

Please suggest test that it is really working Idea ti use client helper s fixture

Hi @Yarboa, I cant figure out how or what exactly to check here, would appreciate further guidance here

Why did you add crispy-form? add a form and test it works with crispy

[paOmer]

Please suggest test that it is really working Idea ti use client helper s fixture

Hi @Yarboa, I cant figure out how or what exactly to check here, would appreciate further guidance here

Why did you add crispy-form? add a form and test it works with crispy

I have repurposed this PR to edit the login form along installing django-crispy-forms in order to have a form to test on.

I have tried to use the client fixture in order to test crispy, though couldn't find a way. I tried the following: response = client.get("/login/") and couldn't find any reference to crispy, not in response.context in general, and not in response.context['form'] in specific.

I can offer a visual test:

• when not applying the crispy tag, meaning only mentioning {{ form }} in the login.html I get the following outcome:

• when applying {{ form.as_p }}, I get the following outcome:

• when applying the crispy tag {{ form|crispy }}, I get the following outcome:

[Yarboa]

Please suggest test that it is really working Idea ti use client helper s fixture

Hi @Yarboa, I cant figure out how or what exactly to check here, would appreciate further guidance here

Why did you add crispy-form? add a form and test it works with crispy

https://github.com/redhat-beyond/JobSeeker/blob/main/login/tests.py

Please update the test to verify login process, please look here as sample https://github.com/redhat-beyond/beyond-tutorial/blob/main/msgboard/tests.py#L59

[Yarboa]

Please suggest test that it is really working Idea ti use client helper s fixture

Hi @Yarboa, I cant figure out how or what exactly to check here, would appreciate further guidance here

Why did you add crispy-form? add a form and test it works with crispy

I have repurposed this PR to edit the login form along installing django-crispy-forms in order to have a form to test on.

I have tried to use the client fixture in order to test crispy, though couldn't find a way. I tried the following: response = client.get("/login/") and couldn't find any reference to crispy, not in response.context in general, and not in response.context['form'] in specific.

I can offer a visual test:

• when not applying the crispy tag, meaning only mentioning {{ form }} in the login.html I get the following outcome:
• when applying {{ form.as_p }}, I get the following outcome:
• when applying the crispy tag {{ form|crispy }}, I get the following outcome:

try this https://github.com/redhat-beyond/beyond-tutorial/blob/main/msgboard/tests.py#L25-L29