Closed rotem-benzvi closed 4 years ago
@lioramilbaum @rotem-benzvi
CI is broken. The log file is full of errors.
is it the lint CI?
it ok to open PR with lint fixing to all pages in our application?
Are you sure those tests are executed by CI?
our CI doesn't run those tests yet
@lioramilbaum @rotem-benzvi
- CI is broken. The log file is full of errors.
- is it the lint CI? maybe. go over the logs, step by step
- it ok to open PR with lint fixing to all pages in our application? It is
- Are you sure those tests are executed by CI?
our CI doesn't run those tests yet Then change that. How can I get confidence in the contributed code?
ok so me and @liorsicd look over the logs there is 2 things:
finally the CI passed, so its look like this specific test is fine, so we suggest that we merge this PR, and we open issues-
@lioramilbaum , sound ok?
now we can test the gatherer flow from friend request to founds. the commit:
Fix: #105 Fixed: #100