search

redhat-beyond / givit

0 stars 5 forks source link

friends request minor changes #13

Closed nadavshoshan closed 4 years ago

nadavshoshan commented 4 years ago

-minor url changes in the friend request app

boaz0 commented 4 years ago

Can you create a follow-up ticket about moving the cities and items/furnitures to tables in the database?

In addition, can you squash all these commits into one commit with a better title maybe update friends database and fix newline problem

And in the message specify all the changes you have done so far: 1) Remove db.sqlite 2) Added friend_id, special_reqs and isOpen to the friend-request table 3) Added support to the above in friend-request views 4) Fix newline error with git 5) ... etc ...

boaz0 commented 4 years ago

//cc @ifireball can you PTAL?

ifireball commented 4 years ago

The PR message could be better - since it does not include any motivation for the change. The commit message is very good. Approving for now.

nadavshoshan commented 4 years ago

The PR message could be better - since it does not include any motivation for the change- got it!

nadavshoshan commented 4 years ago

@ifireball How do I merge now?