redhat-beyond / givit

0 stars 5 forks source link

Friend feed feature + changes in friend request #33

Closed liorsicd closed 4 years ago

liorsicd commented 4 years ago

Friend feed feature

In our app, all friends need the option to see the founded furniture that answering their request. for that, I build a new feature, FriendFeed, that show the data to the friend.

  1. Delete the old Django app called 'friendfeed' that created for this feature. now the feature is part of 'friendreq' app.
  2. Build basic HTML feed to show the data (rendered by the Django view)
  3. Build the logic side -view, URL, model and assign model to admin control

changes in the friend request

After the first draft, we learned (together with @nadavshoshan) that Django can generate the HTML form from the related model. It's also very helpful when we want to set limits options in the form (Enum).

So after the change now our request form is generated by Django and sends to the HTML file as an object.

  1. edit model - using enum
  2. create a new HTML form and delete the old one
  3. create a ModelForm object (and send it to the new HTML)

another mission that relevant for both features - editing URLs

solve #17 replace #18 and #24

ifireball commented 4 years ago

Generally it would have been better to separate the changes you've made to different PRs in order to allow for quicker and more focused reviews.

The code itself looks ok for now.

Please try to keep your PRs smaller in the future.