search

redhat-beyond / givit

0 stars 5 forks source link

Edit Friend Feed #40

Closed liorsicd closed 4 years ago

liorsicd commented 4 years ago

  1. After changing in model of request #35 (item title multichoice recodes in the DB are now numbers instead of names), it's needed to show in UI the readable name instead of the number.

  2. to solve #22 -

    • edit the 'Feed.html' to connect between the 'match' button to the view, and send the item id
    • edit view method to handle 'match' click and change the entry in the DB
liorsicd commented 4 years ago

@ifireball what is the best way to separate unrelated changes in the same file?

ifireball commented 4 years ago

@liorsicd the best way? put them in different files...

If you can't - send one PR - merge it, then send another.

liorsicd commented 4 years ago

the best way? put them in different files...

If you can't - send one PR - merge it, then send another.

@ifireball Thanks, I will try it next time.