search

redhat-beyond / givit

0 stars 5 forks source link

modification on user management app #70

Closed talkind closed 4 years ago

talkind commented 4 years ago

added a new model to save all extra data needed in registration (address, phone number, etc.)

  1. added a new model
  2. connected the User table with the new model with one-to-one link method. used this link: https://simpleisbetterthancomplex.com/tutorial/2016/07/22/how-to-extend-django-user-model.html

added the extra fields in the registration form page. very small addition

migrations files: very small change

  1. deleted a non relevant migration file (0002_...)
  2. construct a new migration file - 0001_initial.py (replace the old one that was in the remote repository
  3. in order to connect perfectly to already built connection between User and friendreq, I modified the dependencies

fixed #37 #23

talkind commented 4 years ago

hi <!here>, can someone please review my PR - update registration form and user management db.

ifireball commented 4 years ago

@liorsicd if you have legit questions and comments, why do you approve the PR?

liorsicd commented 4 years ago

@ifireball approved because it's a minor issue and not urgent to fix it (in my opinion..) @talkind I opened a ticket about it #71