search

redhat-beyond / givit

0 stars 5 forks source link

Django migration CI #88

Closed liorsicd closed 4 years ago

liorsicd commented 4 years ago

this workflow checks Django migrate operation

starting deal with #58

liorsicd commented 4 years ago

the next step is to run our tests, but this is waiting to #59

ifireball commented 4 years ago

@liorsicd I just want to understand where do you expect the CI you're adding to fail and what would that indicate.

liorsicd commented 4 years ago

@ifireball This CI ends with Django migrate operation, so I expect to catch migration issues.

liorsicd commented 4 years ago

@lioramilbaum

here are the flake8 checks?

in a different workflow #92.

there is a motivation to run migration and linting in the same workflow?

lmilbaum commented 4 years ago

@lioramilbaum

here are the flake8 checks?

in a different workflow #92.

there is a motivation to run migration and linting in the same workflow?

Either way works. I don't have a strong opinion on that.