search

redhat-beyond / givit

0 stars 5 forks source link

Manage adding items by logging module #98

Closed rotem-benzvi closed 4 years ago

rotem-benzvi commented 4 years ago

Our app now handle all the added items in agora.log using django logging module. the commit:

  1. we add to settings.py logging module and 2 loggers- for agora and for requests.
  2. add logs directory that include all the log files.

fixed: #62 fixes: #100

rotem-benzvi commented 4 years ago

Your PR needs a rebase

yes sorry, i solved now the conflict.

rotem-benzvi commented 4 years ago

Do you have a test which validates givit_main()?

not yet, i add issue for gatherer test and link it to this PR - #100

rotem-benzvi commented 4 years ago

The maintainer doesn't have the knowledge/experience in the technology used. The tests which validates the changes provide confidence in the code. Does that make sense?

yes definitely, i will do it 👍