search

redhat-certification / chart-verifier

A rules-based tool to certify Helm Charts.
Apache License 2.0
55 stars 54 forks source link

fix: drop extra .tgz from release artifact #464

Closed jessesimpson36 closed 3 months ago

jessesimpson36 commented 3 months ago

Related to #463

This commit will remove the duplicate .tgz extension from the tarball release artifact.

mgoerens commented 3 months ago

Thanks for your contribution !

This LGTM, @komish ?

jessesimpson36 commented 3 months ago

I'm sorry, I may have made my modifications too fast. @komish , I removed the whitespace edit I unintentionally added. I'm unclear on if there was something else in your review you would like, as you said

whoops - didn't highlight the code. See the next review request for a more accurate representation of what I meant

I think you only meant to highlight the added newline character.

komish commented 3 months ago

@jessesimpson36 You nailed it, thank you!

A quick sidenote, though, I'm fairly certain this doesn't fix the problem you're seeing, but it's still an extra tgz where it doesn't belong, so we'll get this merged shortly.

The issue sits in how openshift-tools-installer is filtering our release assets. I'll look to pursue this either in our pipelines (renaming our assets) or directly with openshift-tools-installer itself. If I pursue the latter, I'll CC you into the conversation, should you want to follow along.

For now, though, I've attached an extra release asset to our 1.13.6 so that your pipeline (and ours) will pass when using openshift-tools-installer.

In my local testing with openshift-tools-installer, it picks up the right release asset now.

Download path of chart-verifier is https://github.com/redhat-certification/chart-verifier/releases
::debug::chart-verifier 1.13.6 files: chart-verifier-1.13.6-linux-amd64.tgz, chart-verifier-1.13.6-sbom.spdx.json, chart-verifier-1.13.6.tgz
Current operating system is linux
::debug::After filterByOS, 1 files remain.
::debug::1 clients remaining; skipping filterByArch.
::debug::1 clients remaining; skipping filterByZipped.
Selecting chart-verifier-1.13.6-linux-amd64.tgz

My apologies! We'll try to get this resolved before our next release.

jessesimpson36 commented 3 months ago

You're the best. Thank you.