refactor and cleanup in download.sh and configure.sh

redhat-cip / config-tools

Config Tools

8 stars 11 forks source link

Closed fcharlier closed 9 years ago

fcharlier commented 9 years ago

refactor calls to puppet apply, add variables used in the different ways to call it
fix potential issue with cd $dir … cd .. if $dir has multiple levels
re-add updated PUPPETOPTS to puppet apply
refactor duplicated code calling generate

sbadia commented 9 years ago

:+1: thanks @fcharlier !

EmilienM commented 9 years ago

:+1: LGTM, I let @Spredzy the final review.

fcharlier commented 9 years ago

@sbadia rebased and added more information to the pull-request