redhat-cip / config-tools

Config Tools
8 stars 11 forks source link

configure.sh no fqdn on step 0 #65

Closed dsavineau closed 9 years ago

dsavineau commented 9 years ago

In I.1.3.0 release all the httpd vhosts present in the image (kibana, pxemgr) are deleted during the step 0 on install-server node.

+ puppet apply /etc/puppet/modules/cloud/scripts/bootstrap.pp
(...)
Notice: /Stage[main]/Apache/File[/etc/httpd/conf.d/userdir.conf]/ensure: removed
Notice: /Stage[main]/Apache/File[/etc/httpd/conf.d/puppetmaster.conf.disabled]/ensure: removed
Notice: /Stage[main]/Apache/File[/etc/httpd/conf.d/puppetboard]/ensure: removed
Notice: /Stage[main]/Apache/File[/etc/httpd/conf.d/pxemngr.conf]/ensure: removed
Notice: /Stage[main]/Apache/File[/etc/httpd/conf.d/welcome.conf]/ensure: removed
Notice: /Stage[main]/Apache/File[/etc/httpd/conf.d/25-kibana.conf]/ensure: removed
Notice: /Stage[main]/Apache/File[/etc/httpd/conf.d/edeploy.conf]/ensure: removed
Notice: /Stage[main]/Apache/File[/etc/httpd/conf.d/README]/ensure: removed

The solution is to use apache::purge_configs: false in the env file (in install-server config) but the fqdn template is not generate during the step 0

hosts:
  install-server:
    profile: install-server
    config:
      apache::purge_configs: false

https://github.com/enovance/config-tools/blob/I.1.3.0/configure.sh#L172-L180

Maybe we can backport some code from J.1.0.0 because fqdn are generated during step 0

https://github.com/enovance/config-tools/blob/J.1.0.0/configure.sh#L223

dsavineau commented 9 years ago

No need to generate fqdn in step 0. I made a PR directly in puppet-openstack-cloud to fix this issue

https://github.com/enovance/puppet-openstack-cloud/pull/758