search

redhat-cip / edeploy

Linux systems provisioning and updating made easy
Apache License 2.0
92 stars 38 forks source link

Configuration file in /var/log #171

Closed morucci closed 9 years ago

morucci commented 9 years ago

/usr/sbin/edeploy requests to find a "configuration value" in /var/log/edeploy/vars. Is "profile" a configuration or a log file ? If this a configuration value I suggest to put it in another place.

/usr/sbin/edeploy script returns an error if the file does not exists (/var/log/edeploy/vars) but does not really uses that profile value, it just displays it if the script is called with the profile argument. So in SF we need to setup that file but we doesn't know what do we need to put as value for profile. Is there an explanation we missed somewhere ?

We tried to create that file with "PROFILE=none" at role building but there is that function edeploy/build/common (clean_chroot) that empty all files in /var/log/ ..

So this issue to request a move of that vars file outside of /var/log

fcharlier commented 9 years ago

@morucci this file is supposed to be populated by calling the set_role method from the configure script. When using eDeploy images on cloud instances, you may have to add a step to create this file at first boot.

fcharlier commented 9 years ago

However, I'm wondering if this file shouldn't be located in /var/lib/edeploy instead of /var/log/edeploy …

morucci commented 9 years ago

Thx françois for the explanation.

For SF we does not use edeploy to deploy hardware nodes, with PXE server etc... AFAIK the configure stuff and set_role are part of that unfortunately. Maybe removing the strong dependency of /var/log/edeploy/vars from /usr/sbin/edeploy could be great ?