search

redhat-cip / openstack-serverspec

The serverspec tests for the puppet-openstack-cloud module
Apache License 2.0
12 stars 13 forks source link

All changes #52

Closed bodepd closed 9 years ago

bodepd commented 10 years ago

This commit series contains all of the changes that I needed to make to the project to get it working with my current cloud deployment.

A few notes:

  1. It adds a ton of new parameters. Enough that we might want to add a defaults section to arch.yaml (so they don't have to be respecified per machine)
  2. It does not maintain backwards compat. You will need to specify new parameters to ensure that you still do the same checks. I had considered coding it in a way to allow backwards compat (basically by defaulting values to what you guys had them set to before), but decided that it would be a cleaner implementation to require the new parameters.
  3. I am not entirely sure if this design makes sense (adding tons of parameters) or if it even make sense to share serverspec code b/c every environment is going to be a little different and it might lead to tons of params. That being said, I would like to have this as a community project so that more people can collaborate on it!
  4. I'm happy to break things up into smaller commits, I just wanted to put everything together at least for an initial review to see how you guys reacted :)
EmilienM commented 10 years ago

Dan, thanks a lot for this contribution highly appreciated. I suggest a new patch to fix some little typos, otherwise all looks good and we have no problem for backward compatibility, we will adapt our deployments to make it work.

Again, don't hesitate to send feedback, and we are open to move it on StackForge as soon you and us feel it's ready.

bodepd commented 10 years ago

thanks for that catch. Sometimes I think I'm slightly dyslexic ;)