redhat-cip / openstack-serverspec

The serverspec tests for the puppet-openstack-cloud module
Apache License 2.0
12 stars 13 forks source link

Improve rbd keyring tests for cinder and glance #71

Open cedlecomte opened 9 years ago

cedlecomte commented 9 years ago

We had a check on the file's permissions and the way we manage the rbd detection.

Co-Authored-By: Dimitri Savineau dimitri.savineau@enovance.com

fcharlier commented 9 years ago

:+1: looks good !

Didn't look, but are there the same tests for the glance keyring and for the keyrings on the compute nodes ?

EmilienM commented 9 years ago

before merging, I'm waiting for the same in hypervisor ;-)

cedlecomte commented 9 years ago

I added the glance tests like @fcharlier asked. Tell me if it's not enough.

fcharlier commented 9 years ago

:+1:

fcharlier commented 9 years ago

:+1: @EmilienM 's query seems to have been implemented