search

redhat-cip / openstack-serverspec

The serverspec tests for the puppet-openstack-cloud module
Apache License 2.0
12 stars 13 forks source link

spec/controller/controller_spec: Split out volume controller checks #73

Closed tremble closed 5 years ago

tremble commented 9 years ago

Move volume_controller to a seperate set of checks so that we can disable cinder

tremble commented 9 years ago

Tied to https://github.com/enovance/openstack-yaml-infra/pull/62

EmilienM commented 9 years ago

:-1: it won't work because RBD check is here: https://github.com/enovance/openstack-serverspec/blob/master/spec/tests/volumecontroller/volumecontroller_spec.rb#L19-L22

While Puppet does it on cloud::volume::storage class: https://github.com/stackforge/puppet-openstack-cloud/blob/master/manifests/volume/backend/rbd.pp#L87-L92

You also need to move out this test to another test (volumestorage ?)

Thanks

EmilienM commented 9 years ago

If you use-case is 'Spinal Stack without Cinder', you need to push your scenario as a new pull request, because until now all scenarios have Cinder, so this pull request does not make sense (yet).

Moreover and for your information, upgrades won't work if your scenario is not on github.