search

redhat-cip / puppet-ceph

Deploy Ceph using puppet
http://ceph.com/
Other
69 stars 73 forks source link

Revert "Manage osd journal as a lvm" #43

Closed ctrlaltdel closed 10 years ago

ctrlaltdel commented 10 years ago

This reverts commit ae66e2226aab65fd1a448866b6ac0a9661b5ac6e.

By default, ceph OSD stores its journal in a regular file at "${osd_data}/journal". This file is created when the OSD is first launched. With this commit, the "${osd_data}/journal" resource is now managed by Puppet and replaced by a symlink to a non-existent (in our setup) LVM device.

Result is that the actual journal content gets deleted (and fortunately backed up in Puppet's clientbucket) and a broken symlink is installed instead.

This is why I think that this commit should be either reverted or that the File["${osd_data}/journal"] resource should depend on a new parameter which defaults to false.

fghaas commented 10 years ago

+1 for revert.

dalgaaf commented 10 years ago

+1

In general IMO the correct way would be to add a sane default for the journal path (simply keep the ceph defaults) and manage lvm or what ever you prefer outside of puppet-ceph and then change the path to the journal via puppet-ceph options.