search

redhat-cop / aap_configuration_template

Ansible Automation Platform Configuration as Code examples template
MIT License
53 stars 31 forks source link

fix settings not merged #47

Closed laurent-indermuehle closed 7 months ago

laurent-indermuehle commented 7 months ago

fix #46

I'm not sure we can use list_merge with recursive together. Or can we?

j-random-geek commented 7 months ago

I had the same issue and did the same thing to make the settings work in my environment (2 AAP installs - one VM-based, one containerized). Seems to work as expected for me.

djdanielsson commented 7 months ago

Did you leave the append or replace it with recursive? @j-random-geek

j-random-geek commented 7 months ago

Did you leave the append or replace it with recursive? @j-random-geek

Sorry, I missed that. I left in the append - this is what's in my own (different environment names, obviously):

controller_settings: '{{ controller_settings_all | ansible.builtin.combine(controller_settings_vm, list_merge="append", recursive=true) }}'

laurent-indermuehle commented 7 months ago

Great, thanks for your addition @j-random-geek. I'm on vacations for one week. I'll commit this change when I'm back.

laurent-indermuehle commented 7 months ago

@djdanielsson I tested to use both list_append and recursive and it seems to work. Thanks @j-random-geek! I added back list_append to this PR.