search

redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
78 stars 47 forks source link

Simple git ssh setup #13

Closed ericzolf closed 3 years ago

ericzolf commented 3 years ago

What does this PR do?

Add new role to setup a minimal Git server

I used already the same approach a few times and it's optimal to quickly setup a minimal, SSH based, Git server typically on Tower itself, for learning and demo purposes.

How should this be tested?

The minimal example in the README is fully functional and you just need the name of a server (e.g. Tower) in your inventory, the defaults are fully functional.

Is there a relevant Issue open for this?

n/a

Other Relevant info, PRs, etc.

I'd be willing to put automated testing but I'd need an example/instructions to start from.

ericzolf commented 3 years ago 
* remove .swp file

Done and added to the .gitignore file (basically merged devel into my branch)

* Check the linting issues

They were gone? But perhaps I forgot to push, anyway they're gone now. The errors in the checks are not related to linting any more, they're just weird pipeline errors.

* Perhaps add something to the readme (or maybe even the main readme) about the relevance of having this role in this collection.

I described the features of the collection in the top README, I think, it's where it fits best.

Altogether good though

Thanks :smile: and thanks for the constructive feedback.

ericzolf commented 3 years ago

I have no damn clue why the pipeline continues to fail, as I can't see any meaningful error message. On my laptop, everything looks fine:

$ ansible-lint -c .github/workflow-config/.ansiblelint.yml --exclude=roles/master_role_example  -v roles
$ ansible-lint -c .github/workflow-config/.ansiblelint.yml --exclude=roles/master_role_example -v roles

The only thing which is strange is the following but it's obviously an error of ansible-lint and the error code is still 0:

$ ansible-lint -c .github/workflow-config/.ansiblelint.yml --exclude=roles/master_role_example -v roles/git_ssh_setup/
Examining roles/git_ssh_setup/tasks/git_users.yml of type tasks
Examining roles/git_ssh_setup/tasks/main.yml of type tasks
Examining roles/git_ssh_setup/meta/main.yml of type meta
Examining roles/git_ssh_setup/tasks/{'file': of type tasks
WARNING: Couldn't open /home/myuser/.ansible/collections/ansible_collections/redhat_cop/tower_utilities/roles/git_ssh_setup/tasks/{'file': - No such file or directory
ericzolf commented 3 years ago

OK, found the issue thanks to @sean-m-sullivan (stupid empty line overseen).