search

redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
78 stars 47 forks source link

A pull request triggers twice the same pipeline #16

Closed ericzolf closed 2 years ago

ericzolf commented 3 years ago

It's not a big issue as long as the pipeline is short, but starts to be annoying when the pipeline takes more time.

I have no experience with GitHub Actions and only slightly more with .travis.yml but the way we solved this issue on another project was to only trigger on commits/branches/tags having specific names (e.g. master/devel, tags looking like release numbers, and branches ending with '_', useful especially when you just want to test the pipeline).

sean-m-sullivan commented 3 years ago

We would be up for selective trigger, I think a lot of us are new to this, but the doing a push/pull trigger at the same time is something that wasn't happening till recently.

Tompage1994 commented 3 years ago

Yeah, @ericzolf we haven't been pushing branches to this repo in general (partly due to permissions), and instead working off of forks. I guess you have permissions so you were able to create other branches.

I assume that is the main cause, and as that isnt the usual flow then we can probably ignore this (unless there is a simple fix which I'm not sure about)

ericzolf commented 3 years ago

There should be an easy fix according to my experience with Travis, which isn't very different from GitHub actions, I'll have a look once I find time. It went down the priority list now that I know, I might be the only one impacted :stuck_out_tongue_winking_eye:

Tompage1994 commented 2 years ago

Don't think this is really an issue anymore