search

redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
80 stars 49 forks source link

fix broken example #192

Closed jon4hz closed 1 year ago

jon4hz commented 1 year ago

This PR fixes a broken example in the aap_setup_install README.

jon4hz commented 1 year ago

Also I noticed that the ansible_become here overrides the become: false in the role automation_platform_installer.config_dynamic L58 which can lead to some issues. For example if you use an ee to execute that role, the task will most likely fail due to the missing sudo package inside the ee.

sean-m-sullivan commented 1 year ago

Not sure what we are trying to fix here, these are set to be list items, not dict items, and the template is working around lists,

could you post what happened that led to an error for this fix?

This has worked for me in the past

aap_setup_prep_inv_nodes:
  database:
    - 'hub.laptop'
  automationhub:
    - 'hub.laptop'
jon4hz commented 1 year ago

Actually, I'm not sure about that anymore either. When I started working with the aap_setup_prepare role, I got a weird template error when the inv_nodes were a list, but I guess the error was caused by something else, although I was pretty sure that changing the list to dict items solved the problem.

I tested my setup again with the nodes provided as a list and now it works, weird. Anyway... sorry for the confusion.

sean-m-sullivan commented 1 year ago

No worries, my worry was more if you had more then one node, the dict option would likely not work, but if you find that error again let us know