redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use

https://galaxy.ansible.com/infra/aap_utilities

GNU General Public License v3.0

74 stars 44 forks source link

fix incorrect download bundle #200

Closed snagoor closed 8 months ago

snagoor commented 9 months ago

What does this PR do?

Incorrect setup bundle is downloaded with 2.4 and RHEL9 version ansible-automation-platform-containerized-setup

How should this be tested?

Detailed bug report is provided here https://github.com/redhat-cop/aap_utilities/issues/199

Is there a relevant Issue open for this?

Provide a link to any open issues that describe the problem you are solving. resolves #199

Other Relevant info, PRs, etc

Please provide link to other PRs that may be related (blocking, resolves, etc. etc.)

snagoor commented 9 months ago

Thank you for the review. Updated the logic to check ansible-automation-platform-setup in file name.

jinalklaulitz commented 9 months ago

Could also please remove or increase the elements on the list slice for __aap_setup_down_images in line 34; at the loop statement for name: Downloading the latest installer of type {{ aap_setup_down_type }}? I'm working with the setup bundle and it was being filtered out since it has more elements now due to the list now including the setup and setup bundle for the containerized setup.

snagoor commented 8 months ago

see also PR #207 which should fix both #199 and #206