redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
81 stars 50 forks source link

Add EDA deployment on OCP #239

Closed derekwaters closed 5 months ago

derekwaters commented 5 months ago

What does this PR do?

Add EDA component deployment to the aap_install_ocp role to allow automated deployment of EDA alongside AAP and Hub components.

How should this be tested?

Adding the aap_ocp_install_eda var definition to an existing use of aap_install_ocp will also deploy the EDA component. An example playbook which installs AAP controller and EDA onto an existing OCP environment is included below:

---
- name: Install AAP and EDA on an existing OCP Cluster
  vars:
    aap_ocp_install_connection:
      host: "{{ ocp_host }}"
      username: "{{ ocp_username }}"
      password: "{{ ocp_password }}"
      verify_ssl: false
      validate_certs: false
    aap_ocp_install_namespace: aap
    aap_ocp_install_operator:
      channel: "stable-2.4"
    aap_ocp_install_controller:
      instance_name: demo-aap
      replicas: 1
      link_text: "Ansible Automation Platform"
    aap_ocp_install_eda:
      instance_name: demo-eda
      replicas: 1
      link_text: "Ansible Automation Platform EDA"

  block:
    - name: Install AAP and EDA
      ansible.builtin.include_role:
        name: "infra.aap_utilities.aap_ocp_install"

Is there a relevant Issue open for this?

No issue open for this

Other Relevant info, PRs, etc

No related info or PRs

branic commented 5 months ago

Hi @derekwaters Thank you for your contribution. I'm starting to look over this PR and test it.

While I in the process of reviewing can you please add a changelog fragment and update the role's readme.

derekwaters commented 5 months ago

Apologies @branic I wasn't doing those changes on my normal dev machine and missed my ansible-lint check. Should all be good now. Thanks!