search

redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
78 stars 47 forks source link

tower_database[...whatever...] is documented almost everywhere, but only used in pre_tasks #32

Closed ericzolf closed 2 years ago

ericzolf commented 3 years ago

The following command shows that tower_database[...whatever...] is documented almost everywhere, but only used in "pre_tasks":

tower_cert/README.md
backup/README.md
install/README.md
pre_tasks/defaults/main.yml
pre_tasks/tasks/main.yml
pre_tasks/templates/inventory.j2
pre_tasks/README.md
restore/README.md

I strongly suspect a wild cut&paste effect. We should do the same exercise of cleaning up README.md resp. defaults/main.yml as I did for the tower_configuration.

_Originally posted by @ericzolf in https://github.com/redhat-cop/tower_utilities/pull/30#discussion_r566645071_

sean-m-sullivan commented 3 years ago

I think the most practicle solution is a mixture of what Tom suggested,

  1. We have variables used in pre-tasks that are used for various methods, AH install, OCP install, Tower install, That users may not know to go to find them in pretasks.

I think the most practicle solution would be to created a Readme that describes these variables that are "shared" and link to it in Pretasks/install/backup/restore roles.

Tompage1994 commented 2 years ago

This has been fixed by the restructure of the repo