redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
78 stars 47 forks source link

pre-tasks inventory.js Automation Hub variables #37

Closed crenwick93 closed 3 years ago

crenwick93 commented 3 years ago

I think this may be a typo?

automationhub_pg_database='{{ tower_ah_pg_database }}' automationhub_pg_username='{{ tower_ah_pg_database }}' automationhub_pg_password='{{ tower_ah_pg_database }}'

Surely we aren't setting all of these as tower_ah_pg_database? Should this not be:

automationhub_pg_database='{{ tower_ah_pg_database }}' automationhub_pg_username='{{ tower_ah_pg_username }}' automationhub_pg_password='{{ tower_ah_pg_password }}'

Tompage1994 commented 3 years ago

Yes. Looks like you're probably right there. Should probably be tower_ah_pg_username and tower_ah_pg_password.

PR very much welcome

sean-m-sullivan commented 3 years ago

Looks like this was fixed in #38, closing.