search

redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
74 stars 45 forks source link

updating group name to automationcontroller for AAP2 #50

Closed djdanielsson closed 2 years ago

djdanielsson commented 2 years ago

What does this PR do?

updated group name from tower to automationcontroller to work with AAP2

How should this be tested?

Automated

Is there a relevant Issue open for this?

Provide a link to any open issues that describe the problem you are solving. resolves #49

Other Relevant info, PRs, etc.

none

djdanielsson commented 2 years ago

If you want to keep support for the older version then maybe we need to add a new variable to say something like aap2: true and in the template we do if aap2 automationcontroller else tower

sean-m-sullivan commented 2 years ago

I'm ok with the change, but thinking we should variablize it. Either Tower or AAP, and keeping this that does the install for all supported 3.8 + 4.0+, but that might get complicated, or just be a different template. Thoughts?

Tompage1994 commented 2 years ago

Agreed, for now at least, let's get a variable (e.g. legacy_tower?) which will make the template resolve correctly for tower/controller as relevant

djdanielsson commented 2 years ago

was this more what you were looking for then?

Tompage1994 commented 2 years ago

Thanks @djdanielsson