redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
74 stars 45 forks source link

Prepare renaming of the collection to aap_utilities #63

Closed ericzolf closed 2 years ago

ericzolf commented 2 years ago

What does this PR do?

How should this be tested?

---
- name: assign given certificates
  hosts: aap21_servers
  gather_facts: false
  become: false
  roles:
    - redhat_cop.tower_utilities.aap_certs

with inventory containing something like:

aap_certs_controller_ssl_cert: "{{ playbook_dir }}/tower.cert"
aap_certs_controller_ssl_key: "{{ playbook_dir }}/tower.key"
aap_certs_autohub_ssl_cert: "{{ playbook_dir }}/pulp.cert"
aap_certs_autohub_ssl_key: "{{ playbook_dir }}/pulp.key"
aap_certs_create_backup: true

By lack of time, I didn't test the backup and restore roles, but they shouldn't be worse than they are today.

Is there a relevant Issue open for this?

no

Other Relevant info, PRs, etc.

We already agreed to rename the collection to aap_utilities in the near future.

I didn't touch kerberos because I wasn't sure it's still relevant (we'd need it inside an EE probably).

sean-m-sullivan commented 2 years ago

I kept looking for the pre task rename, forgetting this was already done. I think the only question is should we append the aap name to all of these when we name it aap_utils It will come out as redhat_cop.aap_utils.aap_install

sean-m-sullivan commented 2 years ago

After discussion it was 3 votes to strip the aap_ prefix from roles and make them still redhat_cop.aap_utils.install

ericzolf commented 2 years ago

As per discussion in the Automation CoP meeting, we wait for a decision on the overall rule and then we act accordingly.