search

redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
80 stars 50 forks source link

Add backup, restore, and restructure collection #7

Closed sean-m-sullivan closed 4 years ago

sean-m-sullivan commented 4 years ago

What does this PR do?

Changes names to be in line with other repositories to remove tower from role names. Adds a pretasks role so shared tasks can be used by install, backup, restore, and future roles. Adds Backup, Restore, and Kerberos roles.

How should this be tested?

against a running tower, has been tested with Tower 3.6 and 3.7

Is there a relevant Issue open for this?

3

kedark3 commented 4 years ago

I'd request @sean-m-sullivan @Tompage1994 to take a look at https://github.com/kedark3/ATCasC/tree/master/roles/tower-backup which is variation of backups I had written earlier this year. It was working fine for us. We were using just JSON dump backup as well.

Tompage1994 commented 4 years ago

I'd request @sean-m-sullivan @Tompage1994 to take a look at https://github.com/kedark3/ATCasC/tree/master/roles/tower-backup which is variation of backups I had written earlier this year. It was working fine for us. We were using just JSON dump backup as well.

That looks good. The full backup uses the same idea as this one. The meta backup is using the tower_recieve module which is deprecated in favour of tower_export. I imagine that will instead be a separate role though

kedark3 commented 4 years ago

@Tompage1994 yup you're right. just wanted to put it on our radar that we can support such meta backups/restores!

sean-m-sullivan commented 4 years ago

I'd request @sean-m-sullivan @Tompage1994 to take a look at https://github.com/kedark3/ATCasC/tree/master/roles/tower-backup which is variation of backups I had written earlier this year. It was working fine for us. We were using just JSON dump backup as well.

That looks good. The full backup uses the same idea as this one. The meta backup is using the tower_recieve module which is deprecated in favour of tower_export. I imagine that will instead be a separate role though

We could likely build it into this role, using the tower export, then user can choose which kind of backup they want, same with restore. If user wants both they'd call the role twice with two different variable sets. Will look over this some more and see about integrating Kedar's work.

Tompage1994 commented 4 years ago

I'd request @sean-m-sullivan @Tompage1994 to take a look at https://github.com/kedark3/ATCasC/tree/master/roles/tower-backup which is variation of backups I had written earlier this year. It was working fine for us. We were using just JSON dump backup as well.

That looks good. The full backup uses the same idea as this one. The meta backup is using the tower_recieve module which is deprecated in favour of tower_export. I imagine that will instead be a separate role though

We could likely build it into this role, using the tower export, then user can choose which kind of backup they want, same with restore. If user wants both they'd call the role twice with two different variable sets. Will look over this some more and see about integrating Kedar's work.

I think my personal preference would be separate roles to do things in different ways (i.e. probably export and import roles). Also I think smaller PRs are better, should probably get this one finished before moving onto the next thing? (again just personal preference)