added ability to set the certs/keys content

redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use

https://galaxy.ansible.com/infra/aap_utilities

GNU General Public License v3.0

74 stars 45 forks source link

Closed MikeCantCode closed 2 years ago

MikeCantCode commented 2 years ago

Adds the ability to set the cert/key content in the aap_certs role.

Re-run the aap_certs role to validate idempotency.

Resolves #70

N/A

ericzolf commented 2 years ago

Looks mostly good to me but:

You didn't extend tasks/autohub.yml
a note that both sets of variables are mutually exclusive might help (it's rather obvious but you never know)

ericzolf commented 2 years ago

Why has my comment been ignored? I still think that it was a valid one and the change isn't complete.

Tompage1994 commented 2 years ago

Sorry! Completely missed your comment! I'll raise a separate PR addressing your review

ericzolf commented 2 years ago

:shrug: sh*** happens, no issue.