redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
74 stars 45 forks source link

Move away setup.log before restarting an installation #80

Closed ericzolf closed 2 years ago

ericzolf commented 2 years ago

I realized that setup.log isn't overwritten by setup.sh if it already exists, so that the log gets lost in such cases (at least if running setup.sh as non-root). There should hence be the possibility to move away a potentially existing setup.log. It's not as easy as it sounds because Ansible doesn't have a good option to move things (I don't think we want to simply remove the log file).

djdanielsson commented 2 years ago

I mean move is just copy and then delete so it should be pretty easy

ericzolf commented 2 years ago

Related to https://issues.redhat.com/browse/AAP-4555 - so it should be implemented as a fix we can easily remove once fixed in the product. @djdanielsson but you should remove only if the copy was successful, nothing one can't overcome, agreed.