search

redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
74 stars 45 forks source link

Added auth to setup validation #86

Closed sabre1041 closed 1 year ago

sabre1041 commented 1 year ago

The aap_setup_install does not currently provide authentication during the validation phase after installation. Without providing credentials, validation never succeeds

Resolves #85

sabre1041 commented 1 year ago

@djdanielsson agree. @sean-m-sullivan might be able to provide some insights

branic commented 1 year ago

IMHO both should be checking the UI url and not require login. The UI for Hub will return a 403 status until it is ready. The UI for controller will return a 200 status before it is ready and while migrations are running so the until should check for that in addition the the 200 status code like:

until: (__aap_setup_inst_result['status'] == 200) and ('migrations_notran' not in __aap_setup_inst_result['url'])
sean-m-sullivan commented 1 year ago

The controller should not require login, and we should probably put in a when its defined in the groups as if someone uses this for JUST one or the other it will fail, However if the corresponding one is configured, it should have the password.However I do find one change needed.