redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
80 stars 49 forks source link

controller_hostname and ah_hostname within aap_setup_install not variabilised #90

Closed alawong closed 2 years ago

alawong commented 2 years ago

within the aap_setup_install role, 2 default variables, controller_hostname, and ah_hostname are used to check if controller and AH are running. However, they are set to (literally):

controller_hostname: aap_setup_prep_inv_nodes['automationcontroller'][0] ah_hostname: aap_setup_prep_inv_nodes['automationhub'][0]

As they are missing the brackets, these tasks fail.

Tompage1994 commented 2 years ago

Good spot. I've accepted your PR (just waiting for it to run through CI)

As a workaround before this can be released, you can set extra vars for the values which are broken, namely:

controller_hostname: "{{ aap_setup_prep_inv_nodes['automationcontroller'][0] }}"
ah_hostname: "{{ aap_setup_prep_inv_nodes['automationhub'][0] }}"