redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
74 stars 44 forks source link

Parametrize OCP controller install #92

Closed branic closed 1 year ago

branic commented 1 year ago

What does this PR do?

Adds paramatization to all settings for the controller installation on OCP via the operator. Also introduces the ability to have the controller installed in a different namespace than the operator (useful for when the operator is cluster-scoped).

The output for errors found during validation is also easier to read.

How should this be tested?

Create a playbook to run the aap_ocp_install role with appropriate variables set (see the README.md in the role).

Is there a relevant Issue open for this?

No

Other Relevant info, PRs, etc

None

branic commented 1 year ago

I think last step is allowing them to be separately set

@sean-m-sullivan can you expand on this a little? I'm not quite sure what you are meaning.

sean-m-sullivan commented 1 year ago

it may be I am alone, but was thinking this should be valid and vice versa

- name: Install AAP on OCP playbook
  hosts: localhost
  gather_facts: false

  vars:
    aap_ocp_install_ocp_connection:
      host: "https://api.crc.testing:6443"
      username: kubeadmin
      password: nYF8X-UBSDn-2hzzS-Tg52E
      validate_certs: false
    aap_ocp_install_namespace: aap-test
    aap_ocp_install_operator:
      channel: "stable-2.2"
    aap_ocp_install_controller:
      instance_name: automationcontroller

  roles:
    - redhat_cop.aap_utilities.aap_ocp_install
branic commented 1 year ago

I agree, that should be a valid config (and I thought I tested a variation like that). I'll test again and fix what's not working.