Closed branic closed 1 year ago
I didn't go (yet) into the details of the review but I'm slightly worried by the explicit validation of ansible_run_tags
.
Let me try to word my worries:
ansible_run_tags
without checking ansible_skip_tags
could lead to unexpected behavior of tags, I'm not fully against it, I'm just wondering if it's a good idea, and open to discussion.
I can remove the tags and just base the task execution on the existence of the variables. The tags do add a level of complexity.
I finally got back around to working on this PR. I rebased it so there wouldn't be any merge conflicts as its been a while. I also simplified the when conditions and removed the use of ansible_run_tags
.
What does this PR do?
Allow each component to be individually installed (operator, controller, hub).
As an example the below playbook will now execute without generating an error for missing hub configuration info and successfully installs the operator and controller.
How should this be tested?
Automated tests are preferred, but not always doable - especially for infrastructure. Include commands to run your new feature, and also post-run commands to validate that it worked. (please use code blocks to format code samples)
Is there a relevant Issue open for this?
No
Other Relevant info, PRs, etc
None