search

redhat-cop / aap_utilities

Ansible Collection for automated deployment of AAP and other objects for general use
https://galaxy.ansible.com/infra/aap_utilities
GNU General Public License v3.0
74 stars 44 forks source link

Incorrect tag??? #97

Closed branic closed 1 year ago

branic commented 1 year ago

https://github.com/redhat-cop/aap_utilities/blob/81be4b98694fb527db51ef1c94511f2131d932e7/roles/aap_remove/tasks/main.yml#L13

I think this tag should not be controller, it should probably be something like hub.

As a side-note based on a comment from @ericzolf (https://github.com/redhat-cop/aap_utilities/pull/93#issuecomment-1242717206) maybe we should instead look at removing all tags from the roles. Thoughts?

sean-m-sullivan commented 1 year ago

agreed on changing to hub, I think that tags are useful but at same time it should be the variable or tag, not both.