redhat-cop / agnosticd

AgnosticD - Ansible Deployer for multiple Cloud Deployers
https://redhat-cop.github.io/agnosticd/
GNU General Public License v3.0
383 stars 489 forks source link

Avoid trying to shutdown or start up terminated AWS instances #1026

Open ghost opened 4 years ago

ghost commented 4 years ago

Describe the bug The lifecycle.yml playbook will attempt to shutdown or start all instances that match a guid. We need to avoid trying to start or stop terminated instances.

To Reproduce Steps to reproduce the behavior, ex:

  1. Install an OpenShift cluster, cluster bootstrap machine will be terminated at the end of install.
  2. Try to stop the cluster with the ocp4-workshop/lifecycle.yml and AWS will report that it cannot stop the terminated instance causing the AgnosticD job to fail.

Expected behavior No AWS terminated instances will be included in the start/stop logic.

Screenshots / logs None.

Versions (please complete the following information):

Additional context So far this is noted in the ocp4-workshop config...could be a bug in others that include a lifecycle play.

ghost commented 4 years ago

I will be merging code soon to fix this.