redhat-cop / automation-good-practices

Recommended practices for all elements of automation using Ansible, starting with collections and roles, continuing with playbooks, inventories and plug-ins... These good practices are planned to be used by all Red Hat teams interested but can of course be used by others.
268 stars 66 forks source link

[close?] Rebuild roles document with new draft #41

Closed bontreger closed 2 years ago

bontreger commented 2 years ago

Updated document to follow contribution standards and clarify the role practice recommendations

ericzolf commented 2 years ago

Please don't merge this PR before #37 is merged, I fear there will be a lot of conflicts, and I was first :smirk:

jscar-hawk commented 2 years ago

Approved on 2022-03-09 Review and resolve by the next meeting.

jscar-hawk commented 2 years ago

Will review and try to get this merged/fixed early next week. We need to accept another PR First.

ericzolf commented 2 years ago

@bontreger PR #37 has been merged, you can rebase and continue to work on your PR.

ericzolf commented 2 years ago

Review necessary once conflict has been resolved.

ericzolf commented 2 years ago

I think we can close this PR @bontreger ?

bontreger commented 2 years ago

Closing, will create individual PRs for any elements that haven't been captured