Added defaults, checks for required params, target_namespace if provided and headers for route status check

redhat-cop / casl-ansible

Ansible automation for Managing OpenShift Container Platform clusters

Apache License 2.0

121 stars 82 forks source link

Added defaults, checks for required params, target_namespace if provided and headers for route status check #383

Closed garethahealy closed 4 years ago

garethahealy commented 4 years ago

What does this PR do?

I've updated the role to follow the simliar structure as 'openshift-replicas-ready'. I've also added a headers option, which is needed when checking auth'ed routes.

How should this be manually tested?

Run role as a post_step with applier.

Other Relevant info, PRs, etc.

Needed by: https://github.com/redhat-cop/pipeline-library/pull/94

Who would you like to review this?

cc: @redhat-cop/casl

oybed commented 4 years ago

@garethahealy any updates/thoughts on the above comments?

garethahealy commented 4 years ago

@oybed ; pushed requested changes. just need to test it tomorrow.

garethahealy commented 4 years ago

ready for review/merge.

garethahealy commented 4 years ago

@oybed ; you good to review/merge?